rootvector2 opened a new pull request, #718: URL: https://github.com/apache/commons-collections/pull/718
`SplitMapUtils.readableMap` returns a `WrappedGet` that implements `Unmodifiable` and blocks `clear`, `put` and `putAll`, but `remove(Object)` delegates to the wrapped `Get`, so the view deletes from the underlying map. The `Map` default methods that route through it inherit the hole, so `remove(k, v)`, `computeIfPresent`, `compute` and `merge` empty it just as well, and `UnmodifiableMap.unmodifiableMap` hands the view straight back on its `instanceof Unmodifiable` check, so re-wrapping does not close it. Found while auditing the library's `Unmodifiable` implementations for mutators that reach the delegate; every other one throws, so the fix stays inside `WrappedGet`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
