rzanner commented on code in PR #430:
URL: https://github.com/apache/commons-beanutils/pull/430#discussion_r3665656194


##########
src/main/java/org/apache/commons/beanutils/DynaProperty.java:
##########
@@ -262,12 +261,14 @@ private Class<?> readAnyClass(final ObjectInputStream in) 
throws IOException, Cl
      * @throws ClassNotFoundException Class of a serialized object cannot be 
found.
      */
     private void readObject(final ObjectInputStream in) throws IOException, 
ClassNotFoundException {
+        // read default values
+        in.defaultReadObject();
+
+        // read custom values
         this.type = readAnyClass(in);
         if (isMapped() || isIndexed()) {
             this.contentType = readAnyClass(in);
         }
-        // read other values
-        in.defaultReadObject();
     }

Review Comment:
   I'll just bump serialVersionUID, as supporting both serialization strategies 
is non-trivial to impossible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to