rootvector2 commented on code in PR #428:
URL: https://github.com/apache/commons-beanutils/pull/428#discussion_r3666076712


##########
src/test/java/org/apache/commons/beanutils/DynaResultSetTest.java:
##########
@@ -123,6 +126,28 @@ public void testGetName() {
 
     }
 
+    /**
+     * With the default {@code lowerCase} option the property name differs 
from the real column name, and the read path resolves it through
+     * {@code getColumnName}. Verify that {@code set} resolves it the same 
way, so the update targets the real column name and not the lower-cased property
+     * name.
+     */
+    public void testSetUsesColumnName() throws Exception {
+
+        final AtomicReference<String> updatedColumn = new 
AtomicReference<String>();

Review Comment:
   makes sense, I'll use the diamond going forward. thanks for merging this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to