kali834x opened a new pull request, #790:
URL: https://github.com/apache/commons-compress/pull/790

   **Unknown file type in a CPIO mode field escapes as 
IllegalArgumentException**
   
   The three header readers gate the mode field on `CpioUtil.fileType(mode) != 
0`, but `CpioArchiveEntry.setMode` accepts only the eight file types CPIO 
defines, so the seven other non-zero `S_IFMT` values (0170000, 030000, ...) 
make it throw a raw `IllegalArgumentException` out of `getNextEntry`, which 
declares `IOException`. Routed the mode through a helper that reports such a 
header as `ArchiveException`, at all three readers.
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to