dxbjavid commented on PR #406: URL: https://github.com/apache/commons-net/pull/406#issuecomment-5114197328
@garydgregory pushed an update addressing both your note and Copilot's. the three locale tests now use junit pioneer's @DefaultLocale instead of setting the default locale by hand; i added junit-pioneer as a test dependency and the version is inherited from commons-parent (1.9.1, which is the Java 8 line). on Copilot's substantive point: forcing the formatter to a Gregorian calendar wasn't quite enough for the recent-date path, because the year appended there is read from the caller's serverTime, and under a Thai default locale that calendar is itself Buddhist, so the parsed instant was still 543 years out. it now reads that year through a Gregorian calendar at the same instant. i also added a recent-date test that passes a Buddhist serverTime and fails without the change. full build is green, checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
