rootvector2 commented on PR #629: URL: https://github.com/apache/commons-csv/pull/629#issuecomment-5116795281
@garydgregory reviewed the copilot comments. The suggestion to extend the fix to `QuoteMode.ALL` doesn't hold: `JiraCsv203Test.testWithoutNullString` (CSV-203) pins that `ALL` writes null as the bare empty field to keep it distinct from a quoted empty string, same rationale as `ALL_NON_NULL`. I tried the extension and it fails that test, so `ALL` stays excluded and the code comment now cites CSV-203. Applied the other two: added an `ALL` assertion to `testPrintNullValueStartingRecord` pinning that encoding, and derived the size assertion in `testPrintRecordsWithObjectArray` from the expected string instead of a magic number. Default `mvn` build is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
