rootvector2 opened a new pull request, #431: URL: https://github.com/apache/commons-beanutils/pull/431
`isPropertySuppressed` compares the raw expression token against the suppressed set, but the mapped-descriptor fallback it guards builds `get<Base>(String)` / `set<Base>(String, ?)` from `MappedPropertyDescriptor.capitalizePropertyName(name)`, so any name that differs only in the case of its first character resolves the same accessor pair and is never matched by the check. With `mappedProperty` suppressed, `mappedProperty(key)` is blocked but `MappedProperty(key)` still reads and writes it, including through `BeanUtilsBean.populate` with a caller-supplied parameter map. Mapped accessors are never JavaBeans property descriptors, so `data.getDescriptor(name)` is always null for them and this check is the only thing in front of the accessor. Comparing on the same capitalized base the descriptor derives keeps the guard and the descriptor from drifting apart again; `capitalizePropertyName` drops to package-private for that. Found while re-auditing the suppression path from #413. `PropertyUtilsTest.testCustomIntrospectionSuppressedMappedPropertyCaseVariant` fails without the runtime change (`MappedProperty` still resolves a `MappedPropertyDescriptor`) and passes with it. Full `mvn` default goal is green: 1284 tests, 0 failures. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
