ppkarwasz opened a new pull request, #32: URL: https://github.com/apache/commons-xml/pull/32
## Why `XmlFactories.newSchemaFactory()` hardcoded W3C XML Schema, while the JAXP API it wraps, `SchemaFactory.newInstance(String)`, lets the caller pick the schema language. Since the library is unreleased there is no compatibility to preserve, so the method itself gains the parameter instead of an overload. ## What - `XmlFactories.newSchemaFactory(String schemaLanguage)` passes the language through to `SchemaFactory.newInstance(String)` and propagates its `IllegalArgumentException`/`NullPointerException` contract. The hardening is enforced through the factory's `LSResourceResolver` hook and hardened source rewriting rather than any implementation-specific setting, so the documented guarantees hold for whichever schema language JAXP locates a factory for. - Call sites in the tests and the site index snippet pass `XMLConstants.W3C_XML_SCHEMA_NS_URI`. - `SchemaFactoryLanguageTest` covers the language-selection contract (an unsupported language surfaces `IllegalArgumentException`); the working W3C path is exercised by the whole schema suite. ## Testing Full surefire matrix green (84 reports, zero failures); the new test runs in the schema-tagged executions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
