alhudz opened a new pull request, #1767:
URL: https://github.com/apache/commons-lang/pull/1767
`Repro`: `Conversion.hexToInt("ａａ", 0, 0, 0, 2)` (two U+FF41 FULLWIDTH LATIN
SMALL LETTER A) returns `170`, the same value as the ASCII `"aa"`, and
`Conversion.hexDigitToInt('٩')` (U+0669 ARABIC-INDIC DIGIT NINE) returns `9`.
Both should throw.
`Cause`: `hexDigitToInt` reads the digit with `Character.digit(hexChar,
16)`, which by its own specification recognises every Unicode decimal digit and
the fullwidth Latin letters U+FF21-U+FF3A / U+FF41-U+FF5A, not only
`0-9a-fA-F`. The sibling converters `hexDigitMsb0ToInt`, `hexDigitToBinary` and
`hexDigitMsb0ToBinary` switch over ASCII and do throw on the same chars, and
`CharUtils.isHex` agrees with them. Since `hexDigitToInt` is the digit decoder
behind `hexToByte`, `hexToShort`, `hexToInt` and `hexToLong`, the whole
hex-string surface accepts homoglyphs, and strings that differ collapse onto
one value.
`Fix`: screen the char with `CharUtils.isHex` before converting, reusing the
message the siblings already use. `Character.digit` occurs once in the library,
so this is the only site; ASCII input is unchanged.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
