jlerbsc commented on PR #1768: URL: https://github.com/apache/commons-lang/pull/1768#issuecomment-5181854752
You're right on all counts, and I'm sorry for the review time this cost. The description was a leftover draft that didn't match what I actually pushed — that's entirely on me. Your point on String.valueOf(char[]) is correct too: it delegates straight to new String(char[]), so the change had no value, and the rationale I gave didn't apply to it. I should also have submitted a single rebased commit and run the default `mvn` goal as the template asks. I've since checked and this pattern is out of scope for the rule I thought I was applying, so the finding itself was wrong at the source. No need to reopen anything, and no follow-up on my earlier offer. Thanks for taking the time to spell out what was wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
