rootvector2 opened a new pull request, #433: URL: https://github.com/apache/commons-beanutils/pull/433
`DateTimeConverter.convertToType` decomposes a `java.sql.Timestamp` into whole seconds with `timestamp.getTime() / 1000 * 1000` and adds the sub-second part back via `timestamp.getNanos() / 1000000`, but integer division truncates toward zero while `getNanos()` is always in `[0, 999999999]` (the JDK constructor borrows a second to normalize a negative fraction), so a pre-epoch timestamp with a non-zero fraction rounds the whole-second term up toward zero and then adds a non-negative nanos term, gaining a full second: `new java.sql.Timestamp(-500L)` (1969-12-31T23:59:59.500Z) converts to epoch millis `500` instead of `-500`. `Math.floorDiv` makes the whole-second term floor so it agrees with the nanos term; every date/time converter inherits this one path and post-epoch values are unchanged. Found auditing the date/time converters; the existing tests only feed positive `System.currentTimeMillis()`, so they never hit it. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
