alhudz commented on PR #1769: URL: https://github.com/apache/commons-lang/pull/1769#issuecomment-5239207834
Yes, I'd keep it. This PR only removes the spurious throws where the reduced result fits an `int`; genuine overflow behaviour is unchanged. Checked on this branch: `getFraction(2, 3).multiplyBy(getFraction(2, Integer.MAX_VALUE))` still throws `overflow: mulPos` since the reduced denominator really is out of `int` range, and `getFraction(Integer.MIN_VALUE, 3).invert()` still throws `overflow: can't negate numerator`. Anyone needing values beyond `int` still wants `BigFraction`, so the note stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
