alhudz opened a new pull request, #1771:
URL: https://github.com/apache/commons-lang/pull/1771
`containsAny`, `containsNone` and `indexOfAny` share one surrogate-aware
guard that only special-cases a `high` surrogate.
1. when the matched char is a `low` surrogate the `!isHighSurrogate(ch)`
term returns a match without checking the preceding high surrogate, so a low
surrogate in the search set matches the low half of a `different` pair in the
input.
2. `StringUtils.containsAny("😀", "🨀".toCharArray())` is `true` and
`indexOfAny` returns `1` although the inputs are U+1F600 and U+1FA00, distinct
code points that only share the low surrogate `\uDE00`; index `1` also lands
inside the pair, so slicing there yields malformed UTF-16.
Extended the guard so a low surrogate that is the trailing half of a pair in
the search set only matches when the input carries the same high surrogate
immediately before. Lone surrogates, BMP chars and matching pairs are unchanged.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
