rootvector2 opened a new pull request, #632: URL: https://github.com/apache/commons-csv/pull/632
`CSVFormat.readObject` restores the fields and reinitializes the transient `writeLock`, but it never calls `validate()`, so deserialization is the one path that builds a `CSVFormat` without the invariant checks the constructor runs. A crafted stream can therefore carry a state the `Builder` refuses, such as the quote character equal to the delimiter, `QuoteMode.NONE` with no escape character, or duplicate headers. I hit this while auditing the `Serializable` surface against the constructor's `validate()`. Call `validate()` in `readObject` once the fields are restored and rethrow its `IllegalArgumentException` as `InvalidObjectException`, so a hostile stream is rejected at read time instead of surviving as a broken format that later misparses input or throws from deep inside a print/parse callee. `readObject` is the only place that guards the deserialization path, since the `Builder` and constructor never see it. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
