arimu1 opened a new pull request, #439: URL: https://github.com/apache/commons-cli/pull/439
Fixes https://issues.apache.org/jira/browse/CLI-354 Wrapped `HelpFormatter` descriptions are not indented consistently. Continuation lines whose remaining pad equals the indent (`restLen == indent`) skip the leading indent and apply those spaces on the right instead, so some wrapped lines sit one space left of the others. `TextStyle.pad` currently uses `restLen > indent`. Full-width continuation lines from `TextHelpAppendable.makeColumnQueue` are already limited to `maxWidth - indent`, so `restLen` is exactly `indent` and the indent is dropped. Changing the comparison to `>=` matches the reporter's diagnosis and aligns every continuation line. This does not change wrapping itself. Gary noted that `setMaxWidth(6)` wrapping is messy; that is left alone. ### Tests - `TextStyleTest.padTestData`: remaining pad equal to indent (`maxWidth == text.length + indent`). - `HelpFormatterTest.testPrintHelpWrappedDescriptionIndent`: long option description; continuation lines share the same indent. On unfixed master the new pad case expected `" Hello world"` and got `"Hello world "`. After the change, `mvn test` is 991/0 fail/61 skip (Temurin 21). `checkstyle:check`, `pmd:check`, and `spotbugs:check` are clean. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Grok 4.6 (xAI) implemented the reporter's one-character `>` to `>=` change and the unit tests. No third-party code was copied in. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
