rootvector2 opened a new pull request, #437:
URL: https://github.com/apache/commons-beanutils/pull/437

   `FluentPropertyBeanIntrospector.introspect` turns every public method whose 
name starts with the write prefix into a write method without checking 
`Modifier.isStatic`, and `MappedPropertyDescriptor.getMethod` accepts the 
static methods `getMatchingAccessibleMethod` returns (unlike its sibling 
`internalGetMethod`, which already skips them), so once the fluent introspector 
is registered `BeanUtils.setProperty(form, "locale.default", "fr-FR")` on any 
bean with a `Locale` getter invokes the static `Locale.setDefault` and any 
public static `setX(T)` or `getX(String)`/`setX(String, T)` reachable through a 
nested property becomes writable from a `populate` map; found while auditing 
the introspectors against the JavaBeans rule `java.beans.Introspector` follows 
(static methods are never accessors), fixed by skipping static methods at both 
lookup sites, with regression tests in `FluentPropertyBeanIntrospectorTest` and 
`MappedPropertyTest` that fail without the runtime change.
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to