ppkarwasz commented on PR #44: URL: https://github.com/apache/commons-xml/pull/44#issuecomment-5417007990
Applying the same analysis as in #42: I probed every combination that runs these tests (JDK 8–25 × the stock JDK and Xalan XPath engines, over both DOM parsers) and the hardened evaluation never throws — the entity is declared in the internal subset, so the floor only resolves its external *content* to an empty stream, a legal empty replacement text no parser can reject. Since not throwing is the invariant, c55c682 drops the tolerant try/catch and asserts the strict no-throw/no-leak outcome with `assertDoesNotThrow`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
