[ 
https://issues.apache.org/jira/browse/STATISTICS-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Herbert resolved STATISTICS-98.
------------------------------------
    Fix Version/s: 1.4
         Assignee: Alex Herbert
       Resolution: Fixed

Check the p-value is valid before significance test in commit:

1d9cddccf47a0230a6f57e24e67999dd1046ef8e

 

> SignificanceResult interface does not reject invalid p-values
> -------------------------------------------------------------
>
>                 Key: STATISTICS-98
>                 URL: https://issues.apache.org/jira/browse/STATISTICS-98
>             Project: Commons Statistics
>          Issue Type: Bug
>          Components: inference
>    Affects Versions: 1.3
>            Reporter: Alex Herbert
>            Assignee: Alex Herbert
>            Priority: Trivial
>             Fix For: 1.4
>
>
> The SignificanceResult interface has a default method:
> {code:java}
> default boolean reject(double alpha) {
>     Arguments.checkSignificance(alpha);
>     return getPValue() < alpha;
> } {code}
> The p-value may be outside of the range [0, 1], or NaN. This will invalidate 
> the rejection of a result.
> In cases where a test computes a NaN p-value then the result will be silently 
> accepted when testing using a critical alpha (i.e. not rejected).
> Issue identified using a security scan.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to