kali834x opened a new pull request, #809: URL: https://github.com/apache/commons-compress/pull/809
archiveentry.resolveIn is the default zip-slip guard that expander.expand calls for every entry, and it resolves the untrusted entry name via parentPath.resolve(getName()).normalize(). a name that carries a byte the platform path parser rejects, for example a NUL in a crafted zip central directory record, makes resolve throw an unchecked InvalidPathException out of resolveIn and out of expander.expand, both of which declare only throws IOException, so a caller draining an untrusted archive inside catch(IOException) aborts on an exception it never expects. wrap the resolve and rethrow InvalidPathException as ArchiveException, matching the zip-slip rejection already in the method. the new ArchiveEntryTest case fails before the change with the raw InvalidPathException and passes after. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
