ppkarwasz opened a new pull request, #63: URL: https://github.com/apache/commons-xml/pull/63
Makes the Android instrumented suite green after #62 by gating platform-optional test assertions on probed capabilities instead of platform checks. - `AttackTestSupport` gains seven probe-once constants built on a `supportsConfiguration(Executable)` helper: `DOM_SUPPORTS_SCHEMA`/`SECURE_PROCESSING`/`XINCLUDE` and `SAX_SUPPORTS_RESET`/`SCHEMA`/`SECURE_PROCESSING`/`XINCLUDE`. Each probes the platform default factory once at class load; Android's implementations inherit the throwing JAXP base methods, so the guarded assertions skip there and start running automatically on any platform that adds the capability. - The DOM wrapper-contract tests skip via the existing `DOM_RESOLVES_INTERNAL_ENTITIES` probe where the platform DOM is deliberately left unwrapped. - The `newDefault*` smoke tests drop their obsolete `assertThrows(FactoryConfigurationError)` Android branches (the merged degradation makes the methods succeed) and guard only the FSP assertions; the TrAX variant asserts its documented Android contract, `TransformerFactoryConfigurationError`, since TrAX is outside the degradation's scope. - Every `SecureFactoriesSmokeTest` method now carries the tag of the JAXP factory it exercises, so the smoke tests run across the whole implementation matrix. That exposed the schema smoke tests asserting the stock JDK's `FEATURE_SECURE_PROCESSING` default rather than the library's contract (schema securing is the resolver floor plus secure sub-parsers; FSP is deliberately not set on the factory): they now assert the wrapped `SecureSchema` product instead. Verified: full JVM surefire matrix green; `connectedDebugAndroidTest` on the API 33 emulator green with zero failures (capability-gated tests report as skipped, like `XIncludeTest`). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01MbfpcsKig16HfSe6jGhcvh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
