Weiki886 opened a new pull request, #770: URL: https://github.com/apache/commons-text/pull/770
calculateCost compared the boxed Character values returned by `SimilarityInput.at` with `==`, so it only recognized equal characters that `Character.valueOf` caches. That cache covers values up to 127, so every non-ASCII character compared unequal to itself: applying the distance to `"caf\u00e9"` and `"caf\u00e9"` reported 1 instead of 0, and a two-character CJK input compared against itself reported 2. The adjacent-transposition branch never fired for non-ASCII input either, so transposing two accented characters cost 2 instead of 1. The limited variant was affected the same way and could return -1 for inputs whose real distance is within the threshold. Compare with `Objects.equals` instead, matching every other class in this package: `LevenshteinDistance`, `LevenshteinDetailedDistance`, `JaroWinklerSimilarity` and `HammingDistance` all use `equals` on the values from `at`. --- - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? **Codex (OpenAI GPT-5) was used to discover the bug via automated property-based testing, propose the fix, write the regression tests, and craft this description. Every change was reviewed and verified by a human contributor.** - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that is `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
