lenamonj commented on PR #768:
URL: https://github.com/apache/commons-text/pull/768#issuecomment-5540944845
Thanks Gary, both done in 4933c6a:
1) The negative case is now a valid window that ends before the pattern
completes: `isMatch("xabz", 1, 0, 2)` returns 0 through both overloads. The
out-of-contract case is gone.
2) New `testIsMatchCharSequenceStartDelegatesThroughTheCorrectedOverload`
calls `isMatch("xabz", 1)` and `isMatch("xabz", 2)` directly and expects 2 and
0. All parity assertions now state the expected length explicitly.
Against master's `StringMatcher` all four tests fail (the two-argument call
returns 0 where 2 is expected); with the fix the default `mvn` goal is green,
1895 tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
