lenamonj opened a new pull request, #1784: URL: https://github.com/apache/commons-lang/pull/1784
`Fraction.addSub` runs Knuth 4.5.1 on the operands as given, but the algorithm assumes lowest terms and `getFraction(50, 100)` is stored as 50/100. A shared factor inside an operand survives into the common denominator, so `add` and `subtract` throw `ArithmeticException` while the exact result fits an int (1073741823/2147483646 plus 3/5 is 11/10) and return unreduced results against the reduced form the javadoc promises. #1769 fixed the same shape in `multiplyBy`. Both operands are now reduced before the Knuth step, as `multiplyBy` does. Operands already in lowest terms take the identical path, so the existing overflow and identity assertions hold. Test: `testAddSubtractUnreducedOperands`, red on master and green with the change. Default Maven goal green. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) found the defect and drafted the fix and test; I reviewed them, reproduced the failure on a fresh clone of master, and ran the default Maven goal. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
