lenamonj opened a new pull request, #876:
URL: https://github.com/apache/commons-io/pull/876
`CircularByteBuffer.peek()` returned false early only when `length` was
smaller than the number of buffered bytes. A larger `length` fell through to
the comparison loop, which read past the valid bytes into whatever the backing
array held there, so a fresh buffer holding `{1, 2}` reported an exact match
for `{1, 2, 0, 0}`. Through `PeekableInputStream.peek()` a two-byte stream
matched a four-byte pattern, and a scanner branching on that result took the
branch for content the stream does not contain.
The guard now returns false unless `length` equals the buffered count, the
exact-match rule IO-855 documented.
Tests: `testPeekLongerThanBuffered` and
`testPeekLongerThanInputDoesNotMatch`, red on master and green with the change.
Default Maven goal green.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude (Anthropic) found the defect and drafted the fix and tests;
I reviewed them, reproduced the failure on a fresh clone of master, and ran the
default Maven goal.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
