lenamonj opened a new pull request, #556: URL: https://github.com/apache/commons-imaging/pull/556
`Imaging.writeImage` with `ImageFormats.PBM`, `PGM` or `PAM` writes a P6 PPM. `PnmImageParser` accepts all five PNM formats, but `Imaging` passed null parameters, so it always used the default writer. The format reached the parser as `PARAM_KEY_FORMAT` until IMAGING-159 (406f140e, 1.0-alpha3) removed the parameter overloads. `Imaging.writeImage` now calls a protected `writeImageForFormat` hook on `AbstractImageParser`; the base delegates to `writeImage(src, os, null)` and `PnmImageParser` overrides it to set the subtype. PNM keeps the transparency based default. Behaviour change: a transparent image requested as PBM, PGM or PPM now gets that format without its alpha instead of falling through to PAM. The test fails on master with `PBM ==> expected: <P4> but was: <P6>`; the default Maven goal passes with 1260 tests. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) found the defect and wrote the patch and the test; I reviewed them, reproduced the failure on a fresh clone of master, and ran the default Maven goal. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
