alhudz opened a new pull request, #1788:
URL: https://github.com/apache/commons-lang/pull/1788
`FastTimeZone.getGmtTimeZone(String)` is documented to return a `TimeZone`
for any input matching its lenient GMT regex, and `null` only when the regex
fails. It doesn't: a matching offset whose hours or minutes are out of range
throws an undeclared `IllegalArgumentException` from the `GmtTimeZone`
constructor.
Repro: `FastTimeZone.getGmtTimeZone("GMT+24")` (also `"+24"`, `"-24"`,
`"+99"`, `"+12:60"`).
Expected: a `TimeZone`, or `null` (the documented failure signal).
Actual: `IllegalArgumentException: 24 hours out of range`.
`getTimeZone("GMT+24")` inherits the throw, since it calls `getGmtTimeZone`
before its Olson fallback.
Cause: the regex groups `(\d\d?)` accept `0`-`99`, but the parsed
`hours`/`minutes` go straight into `new GmtTimeZone(...)`, which rejects `hours
>= 24` / `minutes >= 60`.
Fix: return `null` for an out-of-range offset inside `getGmtTimeZone`, so
`getTimeZone` falls back to the JDK lookup like any other unrecognised id.
Valid offsets and the lenient partial-input cases (`""`, `"+"`, `"GMT"`) are
unchanged; the `ISO8601` and named-zone strategies in `FastDateParser` already
constrain or null-check the value, so this is the sole parse-driven site.
The added `FastTimeZoneTest` cases fail on the current source (both error
with `IllegalArgumentException`) and pass after the change.
---
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude (Anthropic) helped locate the defect and draft the patch,
tests and description; I reviewed the change and verified it locally (default
`mvn` build and tests green).
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
