ppkarwasz opened a new pull request, #86: URL: https://github.com/apache/commons-secure-xml/pull/86
Filters produced by `newXMLFilter` currently forward a caller's `null` `InputSource` unchanged into the `SAXSource` that drives the transformation. That is the correct decorator behavior, since `SAXSource.getInputSource()` is documented as nullable. Xalan-based TrAX implementations, however, dereference the `InputSource` without a null check, so the call fails with an NPE. The divergence comes from the transformation step: Xalan's own `XMLFilter` implementation does not go through a `Transformer`, whereas ours does. Passing `null` to `parse` therefore works against the stock Xalan filter but throws against ours. Apache CXF's [`XSLTJaxbProvider`](https://github.com/apache/cxf/blob/34917285126fb31e63c14bcdbd297919023748a5/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/XSLTJaxbProvider.java#L275-L282) is one caller that relies on `null` being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
