Alwaysgaurav1 commented on PR #1789:
URL: https://github.com/apache/commons-lang/pull/1789#issuecomment-5652079955
Hello @garydgregory,
Thank you for the thorough review! I have addressed all five points in the
latest push (commit df5c62c):
1. **Bounded `T[]`, `List<T>`, and `<T extends Number, S extends T>`
formatting**: Added dedicated tests (`testBoundedGenericArrayTypeToString`,
`testBoundedParameterizedTypeArgumentToString`, and
`testDependentBoundsClassAndTypeParametersToString`) verifying that type
variables in arrays, type arguments, and dependent type bounds format as type
references without expanding recursively.
2. **Bounded variable passed to `toLongString()`**: Updated `toLongString`
to route through `toString(typeVariable)` for cycle safety, and added
`testToLongStringBoundedTypeVariable` covering single bounds, dependent bounds,
multi-bounds, interface bounds, and recursive class bounds.
3. **Parameterized owner with a non-generic inner class**: Added
`testParameterizedOwnerWithNonGenericInnerClassToString` exercising removal of
`<>` for both `parameterizeWithOwner(...)` and reflective method return types.
4. **Defensive copying of lower bounds**: Updated
`testWildcardTypeBuilderDefensiveCopy` to test input array and getter return
defensive copying for both upper and lower bounds.
5. **Owner cycles, repeated sibling references, and exception cleanup**:
- Routed non-Class owner formatting through `toString(useOwner)` so owner
cycles are guarded, adding `testCyclicOwnerParameterizedTypeToString`
(self-cycles and mutual owner cycles).
- Added `testRepeatedSiblingReferencesToString` verifying that identical
sibling type instances in a graph are not falsely flagged as cycles.
- Added `testThreadLocalCleanupAfterException` verifying clean unwind of
the `ThreadLocal` guard after exceptions (unsupported types, custom exceptions,
nested exceptions) and correct subsequent behavior.
All 442 tests in `TypeUtilsTest` pass, and Checkstyle reports 0 violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
