rootvector2 opened a new pull request, #783: URL: https://github.com/apache/commons-vfs/pull/783
`extractUserInfo` and the host name scan in `HostFileNameParser` do not stop at `#`, so `http://allowed.example#@169.254.169.254/` resolves to `169.254.169.254` and `http://allowed.example#.evil.example/` to a host under `evil.example` while `java.net.URI` and `java.net.URL` both report `allowed.example`, an SSRF host-allowlist bypass through userinfo-host confusion that every host-based provider inherits, found while comparing VFS authority parsing against the JDK parsers, and the fix ends both scans at `#` as RFC 3986 section 3.2 requires so these URIs fail with `missing-hostname-path-sep` the way `ftp://host?a` already does, while `%23` in credentials and `#` inside a path keep working. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code, to find the parsing difference against the JDK parsers and to write this patch and its test cases; the default `mvn` build was run locally and passes. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
