prathambhalla12dev opened a new pull request, #1806: URL: https://github.com/apache/commons-lang/pull/1806
## Summary Fixes [LANG-1810](https://issues.apache.org/jira/browse/LANG-1810). `SOFT_MAX_ARRAY_LENGTH` was introduced as a non-final public static field, which violates the convention that public constants should be immutable. It was subsequently deprecated in #1559 in favor of the correctly-declared `SAFE_MAX_ARRAY_LENGTH`. This PR makes `SOFT_MAX_ARRAY_LENGTH` final so that the field is immutable for the remainder of the 3.x lifecycle, and updates its Javadoc to simply point to the replacement. ### Changes | File | Change | |------|--------| | `ArrayUtils.java` | Add `final` to `SOFT_MAX_ARRAY_LENGTH`; simplify deprecation Javadoc | | `ArrayUtilsTest.java` | Assert both fields are `final` via reflection | | `changes.xml` | Add LANG-1810 fix note | ## Test plan - [x] `mvn test -Dtest=ArrayUtilsTest#testMaxArrayLength` — passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
