dxbjavid opened a new pull request, #410: URL: https://github.com/apache/commons-net/pull/410
RExecClient documents that verification of the remote host providing a separate error stream is enabled by default, and the sibling FTPClient initialises the same flag to true, but here the field is left uninitialised so it defaults to false. That means the anti-hijacking check in createErrorStream is skipped unless a caller turns it on by hand, so an attacker who is monitoring the rexec or rcmd negotiation can race a connection to the advertised error-stream port and have it accepted as the remote process's stderr. This initialises the flag to true so the documented default is honoured; RCommandClient and RLoginClient inherit the field, and the added tests fail on master and pass with the change. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Anthropic's Claude (via Claude Code) helped locate the issue, draft the one-line change and the unit tests, and write this description; I reviewed the change and verified the build and tests. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
