alhudz commented on PR #1800: URL: https://github.com/apache/commons-lang/pull/1800#issuecomment-5980888288
Sorry for the delay on this one. The Copilot finding was valid and is fixed in 3808d5d: the `G` rule now takes the era name from the calendar being formatted, so a Gregorian calendar passed to a `ja_JP_JP` printer prints `西暦` again and not `明治`. Repro and details are in the review thread, and `testEraMixedCalendarTypes` covers the mixed calendar types. The full test suite and the checkstyle, PMD, SpotBugs, RAT, japicmp and javadoc checks pass locally on JDK 21. The CI run for the new commit is waiting for approval. `FastDatePrinter` has no Commons Text counterpart, so there's nothing to port. Marked ready for review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
