kwin commented on code in PR #112:
URL:
https://github.com/apache/commons-secure-xml/pull/112#discussion_r4219400985
##########
src/main/java/org/apache/commons/xml/secure/FallbackIgnoreEntityResolver2.java:
##########
@@ -114,8 +119,12 @@ public InputSource getExternalSubset(final String name,
final String baseURI) th
* @throws IOException Thrown if an overriding implementation encounters
an I/O error; never thrown by the default implementation.
*/
private InputSource onUnresolved(final String name, final String publicId,
final String baseURI, final String systemId) throws SAXException {
+ SAXParseException forbiddenException = new
SAXParseException(SecureException.forbidden(name, null, publicId, systemId,
baseURI), locator);
if (SecureException.throwOnUnresolved()) {
- throw new SAXException(SecureException.forbidden(name, null,
publicId, systemId, baseURI));
Review Comment:
Any reason why just a generic SAXException has been thrown before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
