zemiles commented on PR #1810: URL: https://github.com/apache/commons-lang/pull/1810#issuecomment-6062475408
Thanks for the suggestion. Although annotation member methods are public, their declaring annotation type can be package-private. The accessibility override is still needed in that case. Removing this call breaks two existing regression tests in AnnotationEqualsTest due to IllegalAccessException on Java 8, 11, 17, 21, 25, and 27. Restoring the call while keeping the consolidated member checks passes the full Maven build on Java 21. I therefore propose retaining this call to preserve support for non-public annotation types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
