kwin commented on code in PR #114:
URL:
https://github.com/apache/commons-secure-xml/pull/114#discussion_r4237602253
##########
pom.xml:
##########
@@ -53,7 +53,8 @@ limitations under the License.
<!-- OSGi bundle metadata: override commons-parent's org.apache.commons.*
defaults. -->
<commons.osgi.symbolicName>org.apache.commons.xml.secure</commons.osgi.symbolicName>
<commons.osgi.export>org.apache.commons.xml.secure.*;version=${project.version};-noimport:=true</commons.osgi.export>
- <!-- The negation drops the JDK-internal package bnd infers from the
reflective Java 8 fallback in SecureXMLInputFactory.newDefaultFactory(). -->
+ <!-- The negation drops the JDK-internal package bnd infers from the Java
8 fallback in SecureXMLInputFactory.newDefaultFactory(),
+ which loads it from the bootstrap loader. -->
<commons.osgi.import>
!com.sun.xml.internal.stream,
Review Comment:
Is Bnd really still generating an import if this is not set? Most probably
this line can be removed due to the system classloader being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
