Alwaysgaurav1 commented on PR #1813: URL: https://github.com/apache/commons-lang/pull/1813#issuecomment-6150387405
@garydgregory I reviewed Copilot's comments: 1. **Test helper extraction (adopted in ef2def3):** Extracted the repeated surrogate validation loop across `testCenterSurrogatePair`, `testLeftPadSurrogatePair`, and `testRightPadSurrogatePair` into a private `assertNoLoneSurrogates(final String result)` helper in `StringUtilsTest`. 2. **Javadoc placement (false positive):** Copilot reported that the Javadocs and examples were placed on the `(..., char)` overloads instead of `(..., String padStr)`. This is a false positive caused by Git diff hunk headers displaying the preceding method signature; in the actual source file, the Javadocs and examples are already attached directly to the `String padStr` overloads of `center`, `leftPad`, and `rightPad`. 3. **Surrogate boundary shortfall:** Already documented in commit 1d69390. Ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
