SABITHSAHEB opened a new pull request, #293: URL: https://github.com/apache/commons-jxpath/pull/293
1. InfoSetUtil.doubleValue maps a Boolean with the two constants reversed: `true` returns `0.0` and `false` returns `1.0`, the opposite of XPath 1.0 (boolean true converts to 1, false to 0) and of `number()` directly below it and `BasicTypeConverter`, which both map true to 1 and false to 0. 2. doubleValue is the numeric coercion behind the arithmetic operators, the relational operators (`<`, `>`, `<=`, `>=`), `floor`/`ceiling`/`round` and the `substring` index arguments, so any comparison or arithmetic that coerces a boolean-valued node or variable is evaluated with the operand negated; a predicate such as `node[flag > 0]` then selects the wrong set of nodes on caller-supplied data, while `number($flag)` on the same value returns the correct result. Swapped the two constants so doubleValue agrees with `number()` and the spec. Added a `CoreFunctionTest` case over the doubleValue path (arithmetic, relational, floor/ceiling/round) that fails before the change and passes after. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) assisted with locating the defect, drafting the one-line fix and the regression test, and writing this description; all changes were reviewed and verified locally against the full test suite. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
