alhudz opened a new pull request, #1821:
URL: https://github.com/apache/commons-lang/pull/1821
`ToStringStyle.JSON_STYLE` quotes and escapes a value only when it is a
`String` or `Character`. Any other value whose `toString()` starts with `{` and
ends with `}` (or `[` / `]`) is appended raw, so that nested objects which
already render as JSON stay nested. A `StringBuilder`, `StringBuffer` or other
non-String `CharSequence` holding text takes that raw path whenever the text is
brace-wrapped, so the same content is escaped as a `String` and injected as a
`StringBuilder`:
```java
String text = "{},\"admin\":true,\"x\":{}";
new ToStringBuilder(o, ToStringStyle.JSON_STYLE).append("name",
text).toString();
// {"name":"{},\"admin\":true,\"x\":{}"}
new ToStringBuilder(o, ToStringStyle.JSON_STYLE).append("name", new
StringBuilder(text)).toString();
// {"name":{},"admin":true,"x":{}}
```
The same happens for `CharSequence` elements of a `Collection` or `Object[]`
and for `Map` values, since they all go through
`JsonToStringStyle.appendDetail(StringBuffer, String, Object)`. The fix treats
every `CharSequence` as a string value in that one method. Output for `String`,
`Character`, a `CharSequence` that is not brace-wrapped, and nested JSON
objects is unchanged. `testCharSequenceIsEscaped` fails before the change and
passes after.
Before you push a pull request, review this list:
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code (Anthropic) found the issue, wrote the patch and the
test, and ran the build; I reviewed the change before submitting.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
