AryanRG opened a new pull request, #548:
URL: https://github.com/apache/commons-dbcp/pull/548

   ## Summary
   
   JDBC interprets a zero-second validation timeout as unlimited. A positive 
sub-second `Duration` currently truncates to zero, so validation can run 
without the requested bound.
   
   Round positive sub-second values up to one JDBC second in both the 
validation-query and `Connection.isValid` paths. Preserve zero/negative values 
as the existing no-timeout behavior, document the conversion, add regressions 
for both paths, and add the DBCP-600 change entry.
   
   Jira: https://issues.apache.org/jira/browse/DBCP-600
   
   ## Validation
   
   - The validation-query regression failed on pristine base and passed with 
this patch.
   - Focused tests and `mvn -q verify` passed locally.
   - The default Maven build (`mvn`) passed locally on this exact tree, 
including a fresh run before publication.
   
   ## Contributor checklist
   
   - [x] Read the project contribution guidelines.
   - [x] Read the ASF Generative Tooling Guidance.
   - [x] AI assistance used: Kiro Opus 5.5 helped identify the defect, prepare 
code/tests/documentation, and perform an independent automated review. The 
Maven results above were checked locally.
   - [x] Run the default Maven build.
   - [x] Add unit tests for the behavioral change.
   - [x] Explain the what, how, and why of the change.
   - [x] Use a meaningful issue-linked commit subject and body.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to