dxbjavid opened a new pull request, #783:
URL: https://github.com/apache/commons-text/pull/783
`StringEscapeUtils.ESCAPE_XSI` backslash-escapes shell metacharacters but
leaves `{` alone, so bash and zsh still apply brace expansion to the escaped
value. `escapeXSI("{report.txt,-delete}")` comes back unchanged, and `bash -c
"find . -name " + escaped` runs `find . -name report.txt -delete`: one escaped
value becomes two arguments, and the second is an option chosen by whoever
supplied the input.
Repro, before the fix: `bash -c "printf '<%s>\n' " +
escapeXSI("{report.txt,-delete}")` prints `<report.txt>` and `<-delete>`. After
the fix it prints one argument, `<{report.txt,-delete}>`. Escaping `{` alone
stops the expansion, the same way the map escapes `[` but not `]`.
`UNESCAPE_XSI` already round-trips `\{`.
The new assertions in `StringEscapeUtilsTest#testEscapeXSI` fail without the
main change and pass with it. The default `mvn` build is green.
---
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
