garydgregory commented on PR #1827: URL: https://github.com/apache/commons-lang/pull/1827#issuecomment-6274952320
-1: Thank you for the contribution. We’re declining this PR because these behaviors are already covered by [testSwapIntRange()](https://github.com/apache/commons-lang/blob/45c80d99559017ea6efcb5db6156bb9a5c850d34/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java#L6397-L6447). That test verifies that swap(array, -1, 2, 2) treats the negative offset as zero. It also verifies that offsets equal to the array length leave the array unchanged, for both offset arguments. The proposed cases exercise the same normalization and bounds-checking paths with different inputs. They do not address an identified coverage gap, so we won’t merge this additional test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
