alhudz opened a new pull request, #1829:
URL: https://github.com/apache/commons-lang/pull/1829

   `ClassUtils.getAbbreviatedName(Class, int)` abbreviates `Class.getName()`, 
and for an array class the first `.` segment is the JVM array encoding plus the 
first package name. `"[Ljava"` gets shortened to `"["`, so the `L` marker and 
the package initial are dropped: `getAbbreviatedName(String[].class, 1)` 
returns `"[.l.String;"`, and `String[][].class` returns the same string, so 
different array types abbreviate identically. With a large enough hint the 
method still returns the full `"[Ljava.lang.String;"`, so only the abbreviated 
path breaks.
   
   The fix keeps the leading `[...[L` prefix and trailing `;` and abbreviates 
only the element class name against the remaining length budget, giving 
`"[Lj.l.String;"` and `"[[Lj.l.String;"`. This is the same encoding 
`getPackageName(String)` and `getShortClassName(String)` already strip in this 
class. Non-array names and primitive arrays (`"[I"`) are unchanged. The `Class` 
overload delegates to the `String` one, so one change covers both. 
`test_getAbbreviatedName_Class_Array` fails before the change (`expected: 
<[Lj.l.String;> but was: <[.l.String;>`) and passes after.
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [x] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [x] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to