Lyin-OTTF commented on PR #333: URL: https://github.com/apache/commons-math/pull/333#issuecomment-6291428938
A note on the red CI on df21ddf, so it does not get read as a problem with this change: the failures are pre-existing on master. This PR sat at action_required for fda0a8a and 92d22cb, so df21ddf is the first commit where the workflows actually ran. The failing tests are all outside the code this PR touches: - FP64FieldDenseMatrixTest.testVeryLargeAllocation — OutOfMemoryError: Java heap space (the test allocates a very large matrix, so it depends on the runner's heap) - CorrelatedVectorFactoryTest.testMath226 - CMAESOptimizerTest.testDiagonalRosen, MultiStartMultivariateOptimizerTest.testRosenbrock, LogitTest.testDerivativesWithInverseFunction, UnivariatePeriodicInterpolatorTest.testSine — all off-by-ulp numeric assertions (5.6e-9 / 5.7e-14 against exact 0.0) master shows the same failures: the Coverage run on master@d3c0eac (https://github.com/apache/commons-math/actions/runs/39334470927) failed on FP64FieldDenseMatrixTest.testVeryLargeAllocation with the same OutOfMemoryError, plus CorrelatedVectorFactoryTest.testMath226 and UnivariatePeriodicInterpolatorTest with the same kind of precision assertion, and the Java CI runs on master@3d15331 failed as well. The summary line of that run is Tests run: 3229, Errors: 1, Flakes: 3 — the surefire flake retry already reruns these. This change only touches org.apache.commons.math4.legacy.stat.descriptive.SynchronizedDescriptiveStatistics and its test (22 tests, all green locally on Windows 11 / JDK 21). The Java CI run on df21ddf (attempt 2) is still queued; I will follow up here if it reports anything that is actually in stat.descriptive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
