garydgregory commented on PR #1837: URL: https://github.com/apache/commons-lang/pull/1837#issuecomment-6387269140
@alhudz Thanks for the fix. In PR #1839, I kept this implementation and _extended_ the regression coverage before applying it locally. Specifically, the PR: - Converts the new tests to JUnit parameterized tests so each input and locale is reported separately. - Covers all three parse overloads, including caller-supplied lenient and strict calendars. - Adds `Integer.MAX_VALUE` cases and verified strict calendars accept ISO days 1–7 while rejecting zero and values above 7. Plus, a correction to the description: non-lenient behavior is not entirely unchanged. Previously, `u = 0` was converted to Sunday and accepted for week-date parsing; it now correctly throws `IllegalArgumentException`. The added strict-calendar test captures that correction. PR #1839 preserve your fix while making its behavior and regression coverage more explicit. I felt that creating an alternate PR would be faster than going round and round on this one. You'll be credited in `changes.xml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
