dajiaohuang commented on PR #873:
URL: https://github.com/apache/commons-io/pull/873#issuecomment-6393026711

   One related boundary to consider: current master now treats Windows 
junctions as link-like directories in `deleteDirectory` (via 
`isLinkLikeDirectory`), but `deleteQuietly` still tests only 
`file.isDirectory()` before recursively cleaning. Since `File.isDirectory()` 
follows a junction, this change's `!isSymlink(file)` guard may still clean a 
junction target on Windows. Could the same link-like-directory predicate be 
applied here, with a Windows junction regression asserting the target contents 
survive? If the existing deletion semantics intentionally differ, please 
clarify that boundary.
   
   AI assistance used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to