sushu0 commented on PR #893: URL: https://github.com/apache/commons-io/pull/893#issuecomment-6445753350
AI-generated update (OpenAI Codex), posted for @sushu0. You're right: the File-to-super-Path delegation test reproduces `StackOverflowError` with the previous runtime change after merging master (`c2331ba`). The Path-to-File bridge has been removed; `WildcardFileFilter` now has no runtime diff against master. The revised dispatch is at the `FileUtils` traversal boundary, before the internal file AND / directory-root OR combinations. It adapts a wildcard File override only when the subclass inherits the base Path implementation. Explicit Path overrides retain priority and their original attributes. Stock AND, OR and NOT combinations are adapted without changing their evaluation order; custom composite Path implementations are retained. Tests also check directory-root short-circuiting, single callbacks, File overrides delegating to each superclass overload, and unchanged Jimfs/null/root Path behavior. Master `308cfd2` was incorporated through merge commit `c2331ba`, followed by fix [98a9ac3](https://github.com/apache/commons-io/commit/98a9ac3b2a3ef82cb676f8caa8c1b75ba633c8b1). This updates the branch without rewriting its published history; the push was a normal fast-forward. Validation on JDK 21: - Pristine `308cfd2` plus the final regressions: 25 tests, 8 failures, no errors/skips. The same 25 pass with the revised runtime. - The expanded six-suite run passes all 106 tests, with no failures/errors/skips: `mvn -Dtest=FileUtilsListFilesTest,WildcardFileFilterTest,FilenameUtilsWildcardTest,AndFileFilterTest,OrFileFilterTest,FileFilterTest test checkstyle:check spotbugs:check`. - Checkstyle: 0 violations. SpotBugs: 0 bug instances. A separate `mvn -U pmd:check` passes. The PR description now reflects this implementation and validation. The full local default build was not repeated, and its checklist item remains unchecked. Earlier full-suite and green CI results are explicitly scoped to their earlier revisions. The PR is ready for re-review. [Java CI for the new head](https://github.com/apache/commons-io/actions/runs/40528264751) is awaiting maintainer approval and has no jobs yet; no current-head hosted test success is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
