oscerd opened a new pull request, #446: URL: https://github.com/apache/commons-cli/pull/446
The table at the top of the `PatternOptionBuilder` Javadoc has the descriptions of `@` and `+` swapped. `@` maps to `Object` and creates an instance of the named class through its no-argument constructor, while `+` maps to `Class` and only loads the class. `PatternOptionBuilderTest.testSimplePattern` already checks it that way (`b@` gives a `Vector`, `f+` gives `Calendar.class`), so only the docs were wrong. Since someone reading the old table could pick `@` thinking they just get a class name back, I also added a short note below the example and on `Converter.OBJECT`, `Converter.CLASS`, `TypeHandler.createObject()` and `TypeHandler.createClass()`: they load whatever class the value names (and `@`/`OBJECT` also runs its constructor), so they shouldn't be used on values from an untrusted source. Javadoc only, no behavior change. - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Claude Opus 5.5) was used to analyze the issue and to prepare the change and this description. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. Not applicable: Javadoc only. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
