aherbert commented on PR #340: URL: https://github.com/apache/commons-math/pull/340#issuecomment-6464098582
Thanks for the modifications. Note that these fixes now have associated Jira tickets: MATH-1693 (BaseRuleFactory) and MATH-1694 (PolynomialUtils). Can you remove the modification of BaseRuleFactory in this PR so it corresponds only to MATH-1694. Then create a new PR for MATH-1693 with the single method change to use `synchronized`. That requires a test. The description for this noted that the existing code can spin indefinitely. A test can be created using JUnit 5 `Assertions.assertTimeoutPreemptively` to show the block of functionality executes within a time frame. The test runner can handle JUnit 4 and JUnit 5 mixed in the same test class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
