garydgregory commented on PR #1843: URL: https://github.com/apache/commons-lang/pull/1843#issuecomment-6467600957
@alhudz Thanks for the fix, merged 🚀 . I added follow-up coverage and clarified the probability assumptions in commit 5ebe419f3bffd4e451bcdf737dfe3d56871af821. Your test reproduces the reported bug. For future contributions, please also consider tests that exercise the affected failure paths and state transitions. Here, that means checking that each rejection path still terminates, acceptance resets the rejection counter, and sparse code-point ranges work alongside custom character arrays. Controlled random sources make these cases reproducible and allow tests to fail promptly if termination breaks. I verified the added coverage against the old cap and variants with the reset or individual rejection-limit checks removed. Those checks help establish that the tests catch regressions, beyond passing with the proposed fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
