garydgregory commented on PR #1849: URL: https://github.com/apache/commons-lang/pull/1849#issuecomment-6563406926
@rys888 Thank you for the PR and addressing LANG-1341. The PR is basically correct but the text needs to be more precise. I addressed this in commit a0b71211f24135f66a4c1328f88d1444fead0349. You are credited in `changes.xml`. Notes: - “The superclass overrides” leaves inherited overrides implicit. The guidance should explicitly cover an `equals(Object)` implementation inherited from an ancestor. - “Makes this builder return false” should identify `isEquals()`, since `appendSuper()` itself returns the builder. - The method documentation should explain both boolean cases: `false` makes the equality result false, while `true` preserves the current result, including an existing false result. - The warning should explain when to omit identity comparison when implementing field-based equality. The PR identifies the right problem, but I wanted the resulting documentation to give users explicit usage guidance and an accurate description of the method’s behavior. The commit supersedes this PR; no runtime implementation change was needed. Closing PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
